Skip to content

Addition of new release and tag workflow files#16

Merged
dan-tw merged 15 commits intoScalablePixelStreaming:v1.0.0from
adrianZahra:newworkflows
Mar 22, 2023
Merged

Addition of new release and tag workflow files#16
dan-tw merged 15 commits intoScalablePixelStreaming:v1.0.0from
adrianZahra:newworkflows

Conversation

@adrianZahra
Copy link
Copy Markdown
Contributor

@adrianZahra adrianZahra commented Mar 16, 2023

Aim: To separate the release of the SPS Frontend from the SPS Framework by adding the ability to tag and release container images of the frontend and to push the frontend npm package all from the frontend repo sepera.

What was added:

  1. tag-workflow.yaml: the github workflow for building container images upon taging
  2. release-workflow.yaml: the github workflow for building and pushing the frontend to NPM when making a github release.
  3. build-images-core.sh: the script that gets our cloud provider and version and builds and pushes our docker container
  4. http-server.dockerfile: the script that gets executed in build-images-core to build our docker container from our npm taged repo

@adrianZahra adrianZahra self-assigned this Mar 16, 2023
dan-tw
dan-tw requested changes Mar 16, 2023
View reviewed changes
Comment thread .github/workflows/tag-workflow.yaml Outdated
Comment thread .github/workflows/tag-workflow.yaml Outdated
Comment thread dockerfiles/http-server.dockerfile Outdated
Comment thread .scripts/linux/pipeline/build-images-core.sh Outdated
Comment thread .github/workflows/tag-workflow.yaml Outdated
Comment thread .github/workflows/tag-workflow.yaml Outdated
Comment thread .github/workflows/tag-workflow.yaml Outdated
Comment thread .github/workflows/tag-workflow.yaml Outdated
Comment thread .scripts/linux/pipeline/build-images-core.sh Outdated
Comment thread .github/workflows/tag-workflow.yaml
dan-tw
dan-tw requested changes Mar 20, 2023
View reviewed changes
Comment thread .github/workflows/tag-workflow.yaml Outdated
@adrianZahra
Copy link
Copy Markdown
Contributor Author

adrianZahra commented Mar 22, 2023

Purpose: The aim of this merge is to merge in the new tag and release workflow files as well as the new sps-frontend docker file. These files will be responsible for carrying out the new release method for the sps frontend.

How to use Tag-Workflow:

  1. bump the version of the sps library
  2. commit the version bump
  3. tag the version git tag v1.0.1dev
  4. commit and push the tag git push && git push origin v1.0.1dev
  5. head to the Actions tab for the SPS Frontend repo to view the workflow https://github.com/ScalablePixelStreaming/Frontend/actions
    The workflow will create an sps-frontend docker image for useage in the tensorworks/sps-frontend repo

How to use the Release-Workflow:

  1. after running the Tag-Workflow successfully head to https://github.com/ScalablePixelStreaming/Frontend/releases/new to create a new release based on the new tag
  2. publish the new release
  3. view the workflow at https://github.com/ScalablePixelStreaming/Frontend/actions
    The workflow will create a new npm package for users to consume

@dan-tw
Copy link
Copy Markdown
Contributor

dan-tw commented Mar 22, 2023

Looks good to me

@dan-tw dan-tw merged commit 457b9da into ScalablePixelStreaming:v1.0.0 Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dan-tw dan-tw dan-tw approved these changes

@david-macpherson david-macpherson Awaiting requested review from david-macpherson

Assignees

@adrianZahra adrianZahra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adrianZahra @dan-tw